Skip to content

fix(ui): Save closes New Connection (open shadow) (#1959) - #1961

Merged
ZhuchkaTriplesix merged 1 commit into
epic/tauri-migrationfrom
issue/ui-modal-scrim-close
Nov 15, 2026
Merged

ZhuchkaTriplesix merged 1 commit into
epic/tauri-migrationfrom
issue/ui-modal-scrim-close

Conversation

@ZhuchkaTriplesix

Copy link
Copy Markdown
Member

Root cause

import { open } from '@tauri-apps/plugin-dialog' shadowed the open prop in the template → v-if=\"open\" was always truthy. Save kept calling connect; the dialog never unmounted.

Fix

  • Rename import → pickSqliteFile; dismiss via v-model:open (Flutter Navigator.pop)
  • Move UI zoom onto .app-frame only; dialogs outside so frosted scrim blur works
  • Teleport New Connection overlay to body

Closes #1959 (follow-up)
Parent: #1843

Test plan

  • typecheck
  • New Connection → SQLite → Save: one connection, dialog gone
  • Backdrop is frosted (bokeh), not just dim
  • Cancel / Esc / backdrop click also dismiss

`import { open }` from the dialog plugin made `v-if="open"` always truthy,
so Save connected forever without dismissing. Rename the import, dismiss via
v-model like Flutter Navigator.pop, and keep UI zoom off modal ancestors so
scrim backdrop-filter (bokeh) works.
@ZhuchkaTriplesix
ZhuchkaTriplesix merged commit 74f45c6 into epic/tauri-migration Nov 15, 2026
3 checks passed
@github-actions github-actions Bot added bug Something isn't working frontend Theme parser epic label: frontend ui User interface components and widgets labels Nov 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working frontend Theme parser epic label: frontend ui User interface components and widgets

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant